Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize the naming of karmada secrets in local up method #5423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

standardize the naming of karmada secrets in local up method #5423

wants to merge 1 commit into from
+237 −172

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Aug 26, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.

However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.

This PR aims to standardize the naming of karmada secrets in local up installation method.

Which issue(s) this PR fixes:

Fixes part of #5363

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

standardize the naming of karmada secrets in local up installation method

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 26, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.58%. Comparing base (840300b) to head (18944b6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5423      +/-   ##
==========================================
- Coverage   38.59%   38.58%   -0.01%     
==========================================
  Files         649      649              
  Lines       45133    45133              
==========================================
- Hits        17417    17414       -3     
- Misses      26380    26382       +2     
- Partials     1336     1337       +1
Flag Coverage Δ
unittests 38.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju force-pushed the secret-local branch 2 times, most recently from cef66b8 to 6d3843d Compare August 26, 2024 08:58
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@chaosi-zju
Copy link
Member Author

/cc @zhzhuang-zju @XiShanYongYe-Chang

@zhzhuang-zju
Copy link
Contributor

/assign

@chaosi-zju
Copy link
Member Author

@zhzhuang-zju can you help review this PR first, and if this PR is okey, I will continue to put forward the other three installation method just referring this.

@chaosi-zju chaosi-zju mentioned this pull request Sep 3, 2024
Open
@zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju can you help review this PR first, and if this PR is okey, I will continue to put forward the other three installation method just referring this.

sure, I'll go through this pr first

zhzhuang-zju
zhzhuang-zju reviewed Sep 3, 2024
View reviewed changes
artifacts/deploy/karmada-scheduler-estimator.yaml Outdated Show resolved Hide resolved
hack/deploy-karmada.sh Outdated Show resolved Hide resolved
hack/deploy-karmada-agent.sh Outdated Show resolved Hide resolved
@zhzhuang-zju
Copy link
Contributor

Generally LGTM, and you could fix the conflicts first

@chaosi-zju chaosi-zju force-pushed the secret-local branch 6 times, most recently from 687b770 to c5e03ee Compare September 5, 2024 09:24
@chaosi-zju chaosi-zju force-pushed the secret-local branch 3 times, most recently from aa909d1 to 6278790 Compare September 20, 2024 08:59
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024
@chaosi-zju chaosi-zju force-pushed the secret-local branch 3 times, most recently from 63170c4 to 28fca6b Compare October 9, 2024 10:34
RainbowMango
RainbowMango reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rainbowmango. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@chaosi-zju
Copy link
Member Author

@RainbowMango this PR is ready~

@chaosi-zju
Copy link
Member Author 

$kubectl get secret -n karmada-system                                                                                      
NAME                                                  TYPE                DATA   AGE
etcd-cert                                             kubernetes.io/tls   3      65m
etcd-etcd-client-cert                                 kubernetes.io/tls   3      65m
karmada-aggregated-apiserver-cert                     kubernetes.io/tls   3      65m
karmada-aggregated-apiserver-config                   Opaque              1      65m
karmada-aggregated-apiserver-etcd-client-cert         kubernetes.io/tls   3      65m
karmada-apiserver-cert                                kubernetes.io/tls   3      65m
karmada-apiserver-etcd-client-cert                    kubernetes.io/tls   3      65m
karmada-apiserver-front-proxy-client-cert             kubernetes.io/tls   3      65m
karmada-apiserver-service-account-key-pair            Opaque              2      65m
karmada-controller-manager-config                     Opaque              1      65m
karmada-descheduler-config                            Opaque              1      65m
karmada-descheduler-scheduler-estimator-client-cert   kubernetes.io/tls   3      65m
karmada-interpreter-webhook-example-cert              kubernetes.io/tls   3      65m
karmada-interpreter-webhook-example-config            Opaque              1      65m
karmada-metrics-adapter-cert                          kubernetes.io/tls   3      65m
karmada-metrics-adapter-config                        Opaque              1      65m
karmada-scheduler-config                              Opaque              1      65m
karmada-scheduler-scheduler-estimator-client-cert     kubernetes.io/tls   3      65m
karmada-search-cert                                   kubernetes.io/tls   3      65m
karmada-search-config                                 Opaque              1      65m
karmada-search-etcd-client-cert                       kubernetes.io/tls   3      65m
karmada-webhook-cert                                  kubernetes.io/tls   3      65m
karmada-webhook-config                                Opaque              1      65m
kube-controller-manager-ca-cert                       kubernetes.io/tls   2      65m
kube-controller-manager-config                        Opaque              1      65m
kube-controller-manager-service-account-key-pair      Opaque              2      65m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@whitewindmills whitewindmills Awaiting requested review from whitewindmills

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@RainbowMango RainbowMango

@zhzhuang-zju zhzhuang-zju

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chaosi-zju @codecov-commenter @zhzhuang-zju @karmada-bot @RainbowMango